Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Naming schema for different binding types #1093

Open
SaschaWillems opened this issue Jul 9, 2024 · 2 comments
Open

[Suggestion] Naming schema for different binding types #1093

SaschaWillems opened this issue Jul 9, 2024 · 2 comments
Labels
framework This is relevant to the framework

Comments

@SaschaWillems
Copy link
Collaborator

With @asuessenbach working hard on unifying the framework I was wondering if we could agree on some naming schema for the different binding types.

Using types aliases already makes things a lot easier to read like this:

// Usings
using BufferAllocationC   = BufferAllocation<vkb::BindingType::C>;
using BufferAllocationCpp = BufferAllocation<vkb::BindingType::Cpp>;

// Usage
vkb::BufferAllocationC do_something();
vkb::BufferAllocationCpp do_something();

Maybe we can improve upon this a little bit by having the C-Binding be the default, and the only suffixing the C++ one?

Like this:

// Usings
using BufferAllocation   = BufferAllocation<vkb::BindingType::C>;
using BufferAllocationCpp = BufferAllocation<vkb::BindingType::Cpp>;

// Usage
vkb::BufferAllocation do_something();
vkb::BufferAllocationCpp do_something();

Just some food for thought and maybe something we can discuss on the next call.

@SaschaWillems SaschaWillems added the framework This is relevant to the framework label Jul 9, 2024
@tomadamatkinson
Copy link
Collaborator

Agreed, this would make it more readable

@asuessenbach
Copy link
Contributor

No problem, if the consensus is to use that naming scheme, I can adjust #1085 accordingly.

@SaschaWillems SaschaWillems changed the title Naming schema for different binding types [Suggestion] Naming schema for different binding types Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework This is relevant to the framework
Projects
None yet
Development

No branches or pull requests

3 participants